Allow a timeout to be passed through SeqConnnection to the underlying HttpClient - #69
Merged
Merged
Conversation
This was referenced Sep 12, 2019
Merged
nblumhardt
added a commit
to nblumhardt/seq-api
that referenced
this pull request
Sep 13, 2019
…Connection.Client.HttpClient.Timeout - no need for breaking ctor change
nblumhardt
added a commit
that referenced
this pull request
Sep 13, 2019
Partial revert of #69 - Timeout is already accessible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this is a binary breaking change, I've taken the liberty of making the (very much implementation-detail)
SeqConnection.LoadResourceGroup()method private, too.(Leaving version set at 5.1 as this package doesn't follow SemVer.)